Multiple updates to the github action corresponding to upstream changes, including dropping support for Python 3.8 #143
Conversation
ojarjur
added
github_actions
There was a problem hiding this comment.
Right on @ojarjur - thank you! I sincerely apologize for the lack of any response - thank you.
|
It seems that our GitHub actions did not pick up jupyterlab/maintainer-tools#255 even though it was merged over a month ago. I'm going to try closing and re-opening the PR to force a re-run and see if the update gets picked up. |
|
@ojarjur - would you like me to push the merge forward? |
|
@kevin-bates thanks, but there's still some additional CI/CD failures that I haven't been able to resolve yet. It probably makes sense to get them all resolved before we try to merge this. However, if you have any ideas how to resolve the remaining issues, they would be greatly appreciated. |
|
Thank you for spending time on this Omar - it's really appreciated! I haven't been able to take a closer look, I'm sorry. |
|
@ojarjur - if it helps, I've elevated your privileges to Also, I'd love to establish easier communication. Would you mind dropping me an email at [email protected] when you get a chance? Thank you. |
ojarjur
changed the title
ojarjur
changed the title
There were some breaking changes to the OS images used by GitHub actions, so we have to incorporate corresponding fixes to our actions: * The conda command is not available on all of our CI/CD images anymore, so we don't print the version of it used. * The JDK version in the images was upgraded past the latest version we support (17), so pinned the version to the older one. * The sbt command line tool is no longer included in the images, so we have to manually install it. Additionally, both jupyterlab/maintainer-tools and jupyter-server dropped support for Python 3.8 late last year. Since we have both of those as dependencies, this change also removes Python 3.8 from the test matrix for gateway_provisioners. Finally, this change also fixes multiple lint failures: * Restoring an accidentally missed lint directive * Reformatting the markdown docs with the latest version of mdformat * Upgrading the pre-commit.ci config to use the latest mdformat version
for more information, see https://pre-commit.ci
|
@kevin-bates Thanks for taking a look earlier. I've had to take several passes over this to finally get all the issues resolved, but I think that's done now and this is ready for review. The big thing to note is that this explicitly removes support for Python 3.8 I couldn't find any other way around that since some many dependencies dropped support for it, so instead I've taken the approach of making it a deliberate and explicit change. Please let me know if you think it's OK to drop support for 3.8 now. |
There was a problem hiding this comment.
This is so great @ojarjur - thank you! I have no worries about dropping support for py 3.8 when it's been EOL for over 6 months, and for these changes to get us to green again - outstanding!
2 participants
This PR makes multiple changes to fix the CI/CD checks due to upstream changes that broke them:
sbtcommand line tool is no longer included in the images, so we have to manually install it.Additionally, both jupyterlab/maintainer-tools and jupyter-server dropped support for Python 3.8 late last year.
Since we have both of those as dependencies, this change also removes Python 3.8 from the test matrix for gateway_provisioners.
Further, this change also fixes lint failures caused by an accidentally missed lint directive and by the markdown docs not being formatted.
Finally, we also fix numerous typing failures that have crept into the code.